Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Powerline docs #422

Closed
wants to merge 3 commits into from

Conversation

JanDeDobbeleer
Copy link
Contributor

@JanDeDobbeleer JanDeDobbeleer commented Oct 3, 2021

A few changes:

  1. There were a few comments from people getting confused by the -RequiredVersion 2.0.412 setting to install oh-my-posh. As that's probably a leftover from a time long passed I removed it.
  2. There's a mention of golang as a requirement to install oh-my-posh on WSL, that's incorrect and a leftover from powerline-go instructions.
  3. To guide users to an easier installation/update experience, I added an info block with this context pointing to the oh-my-posh docs.

As a general question, I wanted to point to a relative URL in point 3, but I have no idea which one to use. If someone can point me in the right direction, would be appreciated!

relates to #420, #413, #404, #382, #370, #369, #364, #363 (the list goes on 😓 )

as this installs an old version of oh-my-posh, the guide below does
not work and is confusing for anyone trying to set this up
@opbld32
Copy link

opbld32 commented Oct 3, 2021

Docs Build status updates of commit 98bf80e:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/tutorials/powerline-setup.md ⚠️Warning View Details

TerminalDocs/tutorials/powerline-setup.md

  • Line 107, Column 102: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/windows/terminal/tutorials/powerline-setup#customize-your-ubuntu-prompt' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 107, Column 102: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/windows/terminal/tutorials/powerline-setup#customize-your-ubuntu-prompt' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mattwojo
Copy link
Collaborator

Hey @JanDeDobbeleer - Thanks for filing this PR. We overhauled the PowerLine / Oh My Posh content in our docs and pointed to your OMP docs quite a bit more. Just did another update - if you have a spare moment to take a look, here's the PR: #467

Thanks for your help here -- OMP is amazing and hopefully we'll get folks on the right path to add some awesome custom themes without the confusion our old content included.

@mattwojo mattwojo closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants