-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: New Win11 screenshot for wsl-gui-screenshot.png #1388
Conversation
Fixes MicrosoftDocs#1381 Line 15 : Windows Subsystem **from** Linux---> Windows Subsystem **for** Linux Very subtle but could be confusing for new readers to the documentation
fix: Fix typo in WSL full form
This screenshot showcases Windows 10 insider being used instead of Win11
This screenshot uses windows 11 as the docs specify.
Docs Build status updates of commit f396398: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Gets an approved from me, if it looks good to you @mattwojo please feel free to merge it! Thank you @Agrover112 for the contribution here! :) |
Docs Build status updates of commit 523da4b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
I'm not ignoring this update --- I just need to do some checking on whether or not we can accept it. There are some very particular guidelines we try to stick to in regard to screenshots -- what icons/logos can be shown from 3rd party apps for example, just trying to do my diligence and will let you know as soon as I have a clear response. |
Yea , I kinda thought this was implied a bit in the screenshots , take your time!. |
Docs Build status updates of commit b5ab461: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Sorry for the delay -- approving and merging. Thanks @Agrover112! |
Thanks ! Are there any other parts of the doc you want me to look at? |
I just updated the tutorial to customize WSL command prompts with Windows Terminal and Oh My Posh if you want to take a look and let me know what you think. Here's the PR: MicrosoftDocs/terminal#467 Thanks again! |
Ah well, i thought it was fine as it is !(PS agree with the creator as well) |
Replaces the Win10 insider screenshot with Win11 screenshot as the docs specify.
I noticed a user was confused because of it.
fixes #1324