Passed AdaptiveCardsHostConfig as a prop to CommonCard #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
reviewed
Jun 21, 2019
corinagum
reviewed
Jun 21, 2019
packages/bundle/src/adaptiveCards/Attachment/AnimationCardAttachment.js
Outdated
Show resolved
Hide resolved
corinagum
reviewed
Jun 21, 2019
packages/bundle/src/adaptiveCards/Attachment/AudioCardAttachment.js
Outdated
Show resolved
Hide resolved
packages/bundle/src/adaptiveCards/Attachment/AudioCardAttachment.js
Outdated
Show resolved
Hide resolved
packages/bundle/src/adaptiveCards/Attachment/SignInCardAttachment.js
Outdated
Show resolved
Hide resolved
corinagum
approved these changes
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2106
Changelog Entry
Fix #2106. Fixed AdaptiveCardHostConfig warning associated with the CommonCard component, by @tdurnford in PR #2108
Specific Changes
I added the AdaptiveCardHostConfig as a prop to CommonCard in the AnimationCards, AudioCards, SignInCards, and VideoCards attachment components. I also set the default value of the image in the AudioCardAttachment component to an empty object since that was throwing an error as well.