Why is subtraction used in _XACTUAL calculation

[orangeccc]

hi,
Good work!
I got a question about your code.
Why is subtraction used in _XACTUAL at

klarfkit/klarfkit/klarfkit.py

Lines 58 to 59 in 8364577

	df['_XACTUAL'] = (df['XINDEX'] * self.die_pitch[0]) + df['XREL'] - self.center_location[0]
	df['_YACTUAL'] = (df['YINDEX'] * self.die_pitch[1]) + df['YREL'] - self.center_location[1]

I think maybe it should be
df['_XACTUAL'] = (df['XINDEX'] * self.die_pitch[0]) + df['XREL'] + self.center_location[0]
df['_YACTUAL'] = (df['YINDEX'] * self.die_pitch[1]) + df['YREL'] + self.center_location[1]?

[orangeccc]

oh, I think i got it.
is the center location means the wafer center coordinate with 0, 0 die as origin?

and i found that the die lines in the output result map is different with another [software's.].
(https://slriley.com/software/klarfview-overview-2/)

(Note the points and lines on the left.)

after i edit the line

klarfkit/klarfkit/klarfkit.py

Line 77 in 8364577

die_x_lines = self.center_location[0] + (i * self.die_pitch[0])

and

klarfkit/klarfkit/klarfkit.py

Line 91 in 8364577

die_y_lines = self.center_location[1] + (i * self.die_pitch[1])

to
die_x_lines = -self.center_location[0] + (i * self.die_pitch[0])
die_y_lines = -self.center_location[1] + (i * self.die_pitch[1]),
then they are exactly the same.

so maybe there shoud be a minus in die lines calculation?

[MichaelHotaling]

Nice find!
I've added the changes into the code base.

df87274