Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad/yet more enhancement #20

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Ad/yet more enhancement #20

merged 9 commits into from
Dec 11, 2024

Conversation

adonesky1
Copy link
Collaborator

@adonesky1 adonesky1 commented Dec 9, 2024

  • Makes the connect method asynchronous in the SDK and provider classes to handle race conditions and ensure proper connection before proceeding.
  • Updates MetaMaskMultichainProvider to wait briefly after attempting to connect, allowing the onDisconnect event to fire if the connection fails, and checking the isConnected flag accordingly.
  • Changes the invokeMethodResults data structure to store both the result and the request object.
  • Moves SDK exports to a new index.ts file
  • Adds a README.md for the SDK

@adonesky1 adonesky1 requested a review from a team as a code owner December 9, 2024 16:13
@adonesky1 adonesky1 force-pushed the ad/yet-more-enhancement branch from 4295eb5 to 743f99d Compare December 11, 2024 20:38
@adonesky1 adonesky1 force-pushed the ad/yet-more-enhancement branch from 743f99d to 617dd65 Compare December 11, 2024 20:40
@adonesky1 adonesky1 merged commit d221ab7 into main Dec 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants