-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ad/yet more enhancement #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
reviewed
Dec 10, 2024
jiexi
reviewed
Dec 10, 2024
…e extensionId in SDK as default
4295eb5
to
743f99d
Compare
743f99d
to
617dd65
Compare
jiexi
reviewed
Dec 11, 2024
jiexi
reviewed
Dec 11, 2024
jiexi
reviewed
Dec 11, 2024
jiexi
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect
method asynchronous in the SDK and provider classes to handle race conditions and ensure proper connection before proceeding.MetaMaskMultichainProvider
to wait briefly after attempting to connect, allowing theonDisconnect
event to fire if the connection fails, and checking theisConnected
flag accordingly.invokeMethodResults
data structure to store both the result and the request object.index.ts
fileREADME.md
for the SDK