Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(socket): type errors #1216

Merged
merged 1 commit into from
Feb 22, 2025
Merged

fix(socket): type errors #1216

merged 1 commit into from
Feb 22, 2025

Conversation

ecp4224
Copy link
Collaborator

@ecp4224 ecp4224 commented Feb 22, 2025

Explanation

This PR fixes the following type errors that surfaced during deployment

#12 [builder 6/6] RUN yarn build
#12 0.231 yarn run v1.22.22
#12 0.276 $ tsc
#12 4.061 src/logger.ts(26,9): error TS2339: Property 'map' does not exist on type '{}'.
#12 4.063 src/logger.ts(35,7): error TS18046: 'searchContext' is of type 'unknown'.
#12 4.063 src/logger.ts(38,14): error TS18046: 'searchContext' is of type 'unknown'.
#12 4.092 error Command failed with exit code 2.
#12 4.093 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#12 ERROR: process "/bin/sh -c yarn build" did not complete successfully: exit code: 2
------
 > [builder 6/6] RUN yarn build:
0.231 yarn run v1.22.22
0.276 $ tsc
4.061 src/logger.ts(26,9): error TS2339: Property 'map' does not exist on type '{}'.
4.063 src/logger.ts(35,7): error TS18046: 'searchContext' is of type 'unknown'.
4.063 src/logger.ts(38,14): error TS18046: 'searchContext' is of type 'unknown'.
4.092 error Command failed with exit code 2.
4.093 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
Dockerfile:9
--------------------
   7 |     RUN yarn install
   8 |     COPY . .
   9 | >>> RUN yarn build
  10 |     
  11 |     # Runtime stage
--------------------
ERROR: failed to solve: process "/bin/sh -c yarn build" did not complete successfully: exit code: 2
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c yarn build" did not complete successfully: exit code: 2

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@ecp4224 ecp4224 self-assigned this Feb 22, 2025
@ecp4224 ecp4224 requested a review from a team as a code owner February 22, 2025 18:20
Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit 6ecc599 into main Feb 22, 2025
28 checks passed
@christopherferreira9 christopherferreira9 deleted the edkek/fix/socket-types branch February 22, 2025 18:38
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (bc0a9a7) to head (820b374).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files         182      182           
  Lines        4351     4351           
  Branches     1066     1066           
=======================================
  Hits         3222     3222           
  Misses       1129     1129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants