Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inline alert (origin mismatch) to SIWE #13773

Open
wants to merge 4 commits into
base: feat/add-blockaid-alert
Choose a base branch
from

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Feb 28, 2025

Description

This PR aims to integrate inline alerts into the Alert System adding the mismatch origin alert (SIWE).

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4227

Manual testing steps

  1. Go to this the test dapp
  2. click on Sign In With Ethereum
  3. Click on the inline alert
  4. Close
  5. Click on Review alert
  6. Acknowledge the alert
  7. Acknowledge the Friction modal and confirm request

Screenshots/Recordings

inline-alert.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 28, 2025
@vinistevam vinistevam force-pushed the feat/add-siwe-alert-request-from branch from 76b1cd2 to 66db022 Compare March 3, 2025 08:59
@vinistevam vinistevam force-pushed the feat/add-siwe-alert-request-from branch from 66db022 to ac6b915 Compare March 3, 2025 11:27
const isSIWE = isSIWESignatureRequest(signatureRequest);

const isInvalidSIWEDomain =
isSIWE && !isValidSIWEOrigin(requestData);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to isValidSIWEOrigin(requestData) this is only for testing the build.

@vinistevam vinistevam marked this pull request as ready for review March 3, 2025 13:36
@vinistevam vinistevam requested review from a team as code owners March 3, 2025 13:36
@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4b9b592
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8e26209-0f9d-4192-8a99-0f8eda2ccb46

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants