-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inline alert (origin mismatch) to SIWE #13773
base: feat/add-blockaid-alert
Are you sure you want to change the base?
feat: add inline alert (origin mismatch) to SIWE #13773
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
76b1cd2
to
66db022
Compare
66db022
to
ac6b915
Compare
const isSIWE = isSIWESignatureRequest(signatureRequest); | ||
|
||
const isInvalidSIWEDomain = | ||
isSIWE && !isValidSIWEOrigin(requestData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert to isValidSIWEOrigin(requestData)
this is only for testing the build.
|
|
Description
This PR aims to integrate inline alerts into the Alert System adding the mismatch origin alert (SIWE).
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4227
Manual testing steps
Sign In With Ethereum
Review alert
Screenshots/Recordings
inline-alert.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist