Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redesign Confirmation bold font weight text #13706

Merged
merged 10 commits into from
Mar 3, 2025
Merged

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Feb 25, 2025

Description

Some text that was meant to be bold is not displaying as bold. This can be observed in Android. It is not visible in iOS.

We should not specify font weights ourselves. Instead, we should opt-in for fontStyles.

e.g. using font-weight 700 when we have not declared a font to display for the weight may cause a different font weight of the font to display.

It seems we specify specific font families rather than mapping the fonts with @ font-face a common font family name

current fontStyles:

  normal: {
    fontFamily: 'EuclidCircularB-Regular',
    fontWeight: '400',
  },
  bold: {
    fontFamily: 'EuclidCircularB-Bold',
    fontWeight: '600',
  },

Related issues

Fixes: #13705

Manual testing steps

  1. Create permit transaction
  2. Observe network account text and Message

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner February 25, 2025 00:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 25, 2025
jpuri
jpuri previously approved these changes Feb 28, 2025
@digiwand digiwand dismissed stale reviews from jpuri and pedronfigueiredo via 3e2cec6 February 28, 2025 15:45
@digiwand digiwand requested a review from a team as a code owner February 28, 2025 15:45
OGPoyraz
OGPoyraz previously approved these changes Feb 28, 2025
@digiwand digiwand enabled auto-merge February 28, 2025 19:40
FrederikBolding
FrederikBolding previously approved these changes Mar 3, 2025
@digiwand digiwand added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@digiwand digiwand added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@digiwand digiwand added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@digiwand
Copy link
Contributor Author

digiwand commented Mar 3, 2025

tests were passing, now merge queue test unit-tests (6) is not
CleanShot 2025-03-03 at 11 13 50@2x

Copy link

sonarqubecloud bot commented Mar 3, 2025

@digiwand digiwand added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Mar 3, 2025
@digiwand
Copy link
Contributor Author

digiwand commented Mar 3, 2025

hi @FrederikBolding @OGPoyraz @pedronfigueiredo, re review please 🙏🏼

tests initially passed, but by merged it was blocked by new changes that needed a snapshot update

@digiwand digiwand added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 78531ba Mar 3, 2025
39 of 41 checks passed
@digiwand digiwand deleted the fix-confirm-font-bold branch March 3, 2025 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Redesign confirmation font weight bold mismatch
6 participants