-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Redesign Confirmation bold font weight text #13706
Conversation
fontStyles.normal includes fontWeight
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
we should not specify fontWeights. Let fontStyles define. Mismatch can lead to no boldness
3e2cec6
658c5e8
|
hi @FrederikBolding @OGPoyraz @pedronfigueiredo, re review please 🙏🏼 tests initially passed, but by merged it was blocked by new changes that needed a snapshot update |
Description
Some text that was meant to be bold is not displaying as bold. This can be observed in Android. It is not visible in iOS.
We should not specify font weights ourselves. Instead, we should opt-in for fontStyles.
e.g. using font-weight 700 when we have not declared a font to display for the weight may cause a different font weight of the font to display.
It seems we specify specific font families rather than mapping the fonts with @ font-face a common font family name
current fontStyles:
Related issues
Fixes: #13705
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist