feat: add MultipleAlertModal component #13683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tamask-mobile into feat/add-alert-modal
|
|
jpuri
reviewed
Mar 3, 2025
| ); | ||
| }; | ||
|
|
||
| export default MultipleAlertModal; |
There was a problem hiding this comment.
Hey @vinistevam : a question for my curiosity. Why is this named as MultipleAlertModal. I was looking at it in extension and found it a bit confusing.
There was a problem hiding this comment.
There are 3 alert modals:
- ConfirmationAlertModal
- AlertModal
- MultipleAlertModal
I am bit confused with functionality of each.
jpuri
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR is adding the
MultipleAlertModalcomponent, which is part of the Alert System.Until we add an alert there is no functional change in the app.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2145
Manual testing steps
Screenshots/Recordings
multi-alert-modal.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist