Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reference): act-1327 - added support eip-6963 #1389

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

TrofimovAnton85
Copy link
Contributor

Description:

  • Added support EIP-6963 ( detect if the user has both MetaMask and MetaMask Flask installed on their browser and if this is the case propose them to pick the wallet to choose to interact with the MetaMask Docs )

How to test:

  • Go to the test page - /wallet/reference/new-reference
  • Test what you can choose from two providers (install them first)
    Screenshot 2024-07-05 at 17 28 10

Links:

JIRA Issue

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:09am

alexandratran
alexandratran previously approved these changes Jul 5, 2024
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrofimovAnton85
Copy link
Contributor Author

LGTM

Hey @alexandratran ! Could you please re-approve
I committed new changes (it turned out that metamask and metamask flask are essentially the same provider and they open at login at the same time, so we removed the choice between them).

@TrofimovAnton85 TrofimovAnton85 merged commit c3a9e47 into main Jul 10, 2024
6 checks passed
@TrofimovAnton85 TrofimovAnton85 deleted the feat-eip-6963 branch July 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants