Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Snaps Resources #1329

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Update Snaps Resources #1329

merged 3 commits into from
Jun 4, 2024

Conversation

Montoya
Copy link
Collaborator

@Montoya Montoya commented Jun 3, 2024 •
edited
Loading

Description

  1. Move Resources page from Reference to Learn
  2. Update outdated resources and add new ones in multiple sections
  3. Add a new section for "Snaps for developers" linking to external documentation for developer-friendly Snaps

Issue(s) fixed

Fixes #974

Preview

https://docs.metamask.io/update-snaps-resources/snaps/learn/resources/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@Montoya Montoya requested review from a team as code owners June 3, 2024 18:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Preview published: update-snaps-resources

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Preview published: update-snaps-resources

@alexandratran alexandratran self-assigned this Jun 3, 2024
alexandratran
alexandratran previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving the "Snaps for developers" section up, right below "Example Snaps." Otherwise LGTM.

@Montoya
Copy link
Collaborator Author

Montoya commented Jun 3, 2024

I would suggest moving the "Snaps for developers" section up, right below "Example Snaps."

Will consider it but for now I'm leaning towards not doing that. Thanks though!

hmalik88
hmalik88 previously approved these changes Jun 4, 2024
View reviewed changes
@Montoya Montoya dismissed stale reviews from hmalik88 and alexandratran via 2f0eb6d June 4, 2024 15:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Preview published: update-snaps-resources

@Montoya Montoya merged commit b10930f into main Jun 4, 2024
8 checks passed
@Montoya Montoya deleted the update-snaps-resources branch June 4, 2024 19:52
@alexandratran alexandratran mentioned this pull request Jun 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@hmalik88 hmalik88 hmalik88 approved these changes

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Snaps for developers" section in Snaps docs
3 participants
@Montoya @alexandratran @hmalik88