Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to important integration steps in SDK guides #1230

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Mar 23, 2024

This PR:

  • Consolidates SDK-specific guides into the "Use SDK" category (Connect and sign, Make read-only requests, Batch RPC requests, and display custom modals)
  • Updates all applicable SDK guides to refer to important integration steps (Infura API key, connect and sign, etc.), and updates examples.

For example: https://docs.metamask.io/1212-sdk-integration/wallet/how-to/use-sdk/javascript/

Fixes #1212

@alexandratran alexandratran requested review from andreahaku and a team March 23, 2024 06:45
@alexandratran alexandratran requested review from a team as code owners March 23, 2024 06:45
Copy link

Preview published: 1212-sdk-integration

You can call any [provider API methods](../../../reference/provider-api.md) using the SDK.
Always call [`eth_requestAccounts`](/wallet/reference/eth_requestaccounts) using
[`request()`](../../../reference/provider-api.md#request) first, since it prompts the installation
or connection popup to appear.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or connection popup to appear.
or connection pop-up window to appear.

or is it a connections dialog box?

https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/p/pop-up

Copy link
Contributor

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 52e4e35 into main Mar 26, 2024
8 checks passed
@alexandratran alexandratran deleted the 1212-sdk-integration branch March 26, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK content to include recommended integration steps
3 participants