-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context, examples, and images to Snaps custom UI #1225
Conversation
Preview published: 843-improve-custom-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just found some issues in the examples.
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Preview published: 843-improve-custom-ui |
Preview published: 843-improve-custom-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improve Snaps custom UI examples to include usage with
snap_dialog
,onTransaction
, oronHomePage
, and include screenshots of all UI components. Minor fixes to images across the site for consistency.Preview: https://docs.metamask.io/843-improve-custom-ui/snaps/features/custom-ui/
Fixes #843
Fixes #890