-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how-to on restricting rpc apis by URL #1223
Conversation
Preview published: zs/restrict-rpc |
I think the tutorial should use the URL library like so: https://codepen.io/m0nt0y4/pen/WNLxYGw Relying on I admit this can cause issues if the request is coming from a host like vercel. The truth is there's no easy way to key based on a URL, it depends on what the developer wants to use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
@Montoya it's my understanding and experience that the |
Preview published: zs/restrict-rpc |
@ziad-saab Oh, maybe my understanding is wrong. If that is true then this approach should work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits to content. LGTM.
Preview published: zs/restrict-rpc |
closes MetaMask/MetaMask-planning#1285.