Add Snaps best practices section #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing due to duplicate routes btw |
|
Preview published: 1163-snaps-best-practices |
Montoya
approved these changes
Mar 6, 2024
|
Preview published: 1163-snaps-best-practices |
|
Preview published: 1163-snaps-best-practices |
|
"Dev Ex" was requested for review but it should have been Snaps. Regardless, I think this can be merged. |
|
Preview published: 1163-snaps-best-practices |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Best practices" section under the "Learn" top-level section. Renames the Snaps design and security guidelines pages and adds them to this section. Fixes #1163.
Preview: https://docs.metamask.io/1163-snaps-best-practices/snaps/learn/best-practices/