Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document snap_getClientStatus #1119

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Document snap_getClientStatus #1119

merged 7 commits into from
Feb 14, 2024

Conversation

ziad-saab
Copy link
Contributor

Closes #1118 .

@ziad-saab ziad-saab requested review from a team as code owners February 1, 2024 19:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snap-getclientstatus

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snap-getclientstatus

@alexandratran alexandratran self-assigned this Feb 1, 2024
alexandratran
alexandratran approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made minor edits and placed getClientStatus in alphabetical order on the reference page. LGTM!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snap-getclientstatus

Montoya
Montoya approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Another detail is when MetaMask is locked, dialogs do not work. We might want to update the documentation for dialogs to call this out.

@ziad-saab ziad-saab marked this pull request as draft February 2, 2024 06:38
@ziad-saab
Copy link
Contributor Author

Thanks for the review. I'll add the bit on dialogs and re-request a review

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Preview published: zs/snap-getclientstatus

@ziad-saab ziad-saab marked this pull request as ready for review February 6, 2024 15:56
@ziad-saab ziad-saab requested a review from a team as a code owner February 6, 2024 15:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Preview published: zs/snap-getclientstatus

alexandratran
alexandratran approved these changes Feb 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Preview published: zs/snap-getclientstatus

@ziad-saab ziad-saab merged commit f53ea78 into main Feb 14, 2024
6 checks passed
@ziad-saab ziad-saab deleted the zs/snap-getclientstatus branch February 14, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montoya Montoya Montoya approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snaps: Document snap_getClientStatus
3 participants
@ziad-saab @Montoya @alexandratran