Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/keyring-{snap-client,internal-api} versions #5356

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 18, 2025

Explanation

Some of the versions were not "aligned", resulting in different keyring-api versions (nothing too breaking though), but this sometimes pollutes the lavamoat policy files once updating the controllers on the extension, so it's "better" to keep them aligned as much as we can.

Was:

├─ @metamask/assets-controllers@workspace:packages/assets-controllers
│  ├─ @metamask/keyring-api@npm:17.0.0 (via npm:^17.0.0)
│  ├─ @metamask/keyring-internal-api@npm:4.0.2 (via npm:^4.0.1)
│  └─ @metamask/keyring-snap-client@npm:3.0.3 [d7116] (via npm:^3.0.3 [d7116])
│     └─ @metamask/keyring-api@npm:16.1.0 (via npm:^16.1.0)
...
├─ @metamask/multichain-transactions-controller@workspace:packages/multichain-transactions-controller
│  ├─ @metamask/keyring-api@npm:17.0.0 (via npm:^17.0.0)
│  ├─ @metamask/keyring-controller@workspace:packages/keyring-controller (via npm:^19.1.0)
│  ├─ @metamask/keyring-internal-api@npm:4.0.2 (via npm:^4.0.1)
│  └─ @metamask/keyring-snap-client@npm:3.0.3 [f7262] (via npm:^3.0.3 [f7262])
│     └─ @metamask/keyring-api@npm:16.1.0 (via npm:^16.1.0)

While the keyring-api being used everywhere else is the 17.0.0.

References

Changelog

See PR's content.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Copy link

socket-security bot commented Feb 18, 2025

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/keyring-snap-client@3.0.3

View full report↗︎

@ccharly ccharly force-pushed the chore/update-accounts-deps branch from ce2611e to d734738 Compare February 18, 2025 14:50
@ccharly ccharly marked this pull request as ready for review February 18, 2025 14:50
@ccharly ccharly requested review from a team as code owners February 18, 2025 14:50
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccharly ccharly enabled auto-merge (squash) February 18, 2025 15:47
@ccharly ccharly merged commit 8e348d8 into main Feb 18, 2025
133 checks passed
@ccharly ccharly deleted the chore/update-accounts-deps branch February 18, 2025 15:52
@ccharly ccharly mentioned this pull request Feb 20, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants