feat: SOL-46 adds the multichain transactions controller package #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone-live
changed the title
zone-live
commented
Jan 13, 2025
zone-live
commented
Jan 13, 2025
mcmire
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Hello! Thanks for pinging us about this. Just had some comments below. I think reaching 100% test coverage to avoid pain in the future, aligning the controller with our controller guidelines, and adjusting the dependencies in package.json are the most important items here.
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsController.ts
Outdated
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsTracker.ts
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsTracker.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-transactions-controller/src/MultichainTransactionsTracker.ts
Show resolved
Hide resolved
|
Hi Elliot @mcmire! I've added your feedback and just left 2 comments! 🙏🏼 If you can approve it now, would appreciate. Thank you for the extra pair of eyes! |
mcmire
reviewed
Jan 16, 2025
packages/multichain-transactions-controller/src/MultichainTransactionsTracker.test.ts
Outdated
Show resolved
Hide resolved
@mcmire updated! 💪🏼 |
|
@mcmire pinging you, please! 🙏🏼 |
zone-live
added a commit
that referenced
this pull request
Jan 27, 2025
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR adds a new package to the Core repo, with the new MultichainTransactions controller, it comes from my original [extension PR](MetaMask/metamask-extension#29129), and it's responsibility is to track transactions for non-EVM accounts, with different block times, by using the Solana and Bitcoin snaps as the data source. It shares the same approach/structure with the MultichainBalancesController, given that responsibilities are very similar. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> It relates to the [PR opened in extension](MetaMask/metamask-extension#29129) that will be updated after this one is merged. ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/multichain-transactions-controller` - **ADDED**: New `multichain-transactions-controller` package, with the `MultichainTransactionsController` to track the transactions for non-EVM accounts by using the Solana and Bitcoin snaps as the data source.. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a new package to the Core repo, with the new MultichainTransactions controller, it comes from my original extension PR, and it's responsibility is to track transactions for non-EVM accounts, with different block times, by using the Solana and Bitcoin snaps as the data source. It shares the same approach/structure with the MultichainBalancesController, given that responsibilities are very similar.
References
It relates to the PR opened in extension that will be updated after this one is merged.
Changelog
@metamask/multichain-transactions-controllermultichain-transactions-controllerpackage, with theMultichainTransactionsControllerto track the transactions for non-EVM accounts by using the Solana and Bitcoin snaps as the data source..Checklist