Fix spec for doc rendering (Part 1) #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandratran
changed the title
jiexi
reviewed
Dec 19, 2024
jiexi
reviewed
Dec 19, 2024
jiexi
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've migrated to v2 of the OpenRPC spec parser for the API reference documentation, there are some missing/inconsistent/confusing details displayed in the rendered docs. This PR tweaks the spec param names, descriptions, etc. for the following methods to make the rendered docs more clear and consistent:
wallet_addEthereumChainwallet_switchEthereumChainwallet_getPermissionswallet_requestPermissionswallet_revokePermissionspersonal_signThe remaining methods will be addressed in future PRs.
Fixes #278
See MetaMask/metamask-docs#1778