Reorder MetaMask API entries #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandratran
approved these changes
Feb 28, 2024
vandan
approved these changes
Feb 29, 2024
joaniekube
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MetaMask/metamask-docs#1148
This PR reorders the API methods by:
ethThese methods do not have labels, but in chatting with @shanejonas , it seems the following methods should be called from the
execution-apis:eth_subscribeeth_unsubscribeeth_sendTransactionweb3_clientVersionFor now, they are just above the other
ethmethods (with the exception of theeth_sendTransaction, which seems to be a bit different) . There is apparently a mismatch in the API of data vs input that needs to be fixed.