add eth_signTypedData_v4 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
add-sign-typed-data
branch
from
7438d16 to
f50f721
Compare
adonesky1
force-pushed
the
add-sign-typed-data
branch
2 times, most recently
from
9902759 to
2f2c168
Compare
adonesky1
commented
Mar 23, 2023
| "rpcUrls": [ | ||
| "https://dai.poa.network" | ||
| ], | ||
| "rpcUrls": ["https://dai.poa.network"], |
There was a problem hiding this comment.
sorry for these random formatting changes... I can revert them if that's desired
adonesky1
force-pushed
the
add-sign-typed-data
branch
from
2f2c168 to
930b735
Compare
shanejonas
reviewed
Mar 28, 2023
openrpc.json
Outdated
| ], | ||
| "result": { | ||
| "name": "Signature", | ||
| "value": "[the signature]" |
There was a problem hiding this comment.
could make this an example signed result
There was a problem hiding this comment.
heres one from the eip:
0x4355c47d63924e8a72e509b65029052eb6c299d53a04e167c5775fd466751c9d07299936d304c153f6443dfa05f40ff007d72911b6f72307f996231605b915621c
shanejonas
reviewed
Mar 28, 2023
Co-authored-by: Shane <jonas.shane@gmail.com>
shanejonas
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #94