Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 3.6: Switch generate_psa_test.py to automatic dependencies for negative test cases #9857

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Backport 3.6: Switch generate_psa_test.py to automatic dependencies for negative test cases #9857

merged 3 commits into from
Jan 20, 2025

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Dec 16, 2024 •
edited
Loading

This completes the forward port of #9025. Everything is happening in the framework, except for removing the exceptions to test coverage that this is fixing.

PR checklist

@gilles-peskine-arm gilles-peskine-arm added component-crypto Crypto primitives and low-level interfaces needs-preceding-pr Requires another PR to be merged first priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Dec 16, 2024
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 16, 2024
Merged
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-3.6 branch from 852861e to 6fa0e62 Compare December 23, 2024 16:28
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-3.6 branch 2 times, most recently from 96c62d3 to 454343b Compare January 9, 2025 20:13
@davidhorstmann-arm davidhorstmann-arm self-requested a review January 15, 2025 11:00
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-3.6 branch from 454343b to 0d19d05 Compare January 15, 2025 13:13
@gilles-peskine-arm gilles-peskine-arm added needs-preceding-pr Requires another PR to be merged first and removed needs-preceding-pr Requires another PR to be merged first labels Jan 15, 2025
This was referenced Jan 15, 2025
Merged
Merged
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-3.6 branch from 0d19d05 to 3f8b222 Compare January 16, 2025 19:02
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-work labels Jan 16, 2025
waleed-elmelegy-arm
waleed-elmelegy-arm previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@waleed-elmelegy-arm waleed-elmelegy-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidhorstmann-arm
davidhorstmann-arm previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thaniks!

@gilles-peskine-arm
Update framework
8e07e27 
Catch up with Mbed-TLS/mbedtls-framework#104 =
"Switch generate_psa_test.py to automatic dependencies for negative test cases"

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Remove test coverage exceptions that are no longer needed
a2a0c39 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Add ignore list entries for ECDH/FFDH algorithm without key type
a6c1f56 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm force-pushed the psa-storage-test-cases-never-supported-negative-3.6 branch from 3f8b222 to a6c1f56 Compare January 20, 2025 14:56
@gilles-peskine-arm
Copy link
Contributor Author

I've rebased after merging Mbed-TLS/mbedtls-framework#104 to get the latest framework update in a way that GitHub's conflict resolution accepts. No other changes.

@gilles-peskine-arm gilles-peskine-arm removed the needs-preceding-pr Requires another PR to be merged first label Jan 20, 2025
davidhorstmann-arm
davidhorstmann-arm approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waleed-elmelegy-arm waleed-elmelegy-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 20, 2025
@gilles-peskine-arm gilles-peskine-arm removed the needs-ci Needs to pass CI tests label Jan 20, 2025
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Jan 20, 2025
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 18e4b3f Jan 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@waleed-elmelegy-arm waleed-elmelegy-arm waleed-elmelegy-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @davidhorstmann-arm @waleed-elmelegy-arm