Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 3.6: Fix incorrect dependencies #9568

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Backport 3.6: Fix incorrect dependencies #9568

merged 4 commits into from
Sep 19, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Resolves #9473

Partial backport of #9385

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01
Add missing ALG_SHA_1
fbab4f8 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01
Replace MBEDTLS_PK_CAN_ECDSA_SOME with MBEDTLS_PK_CAN_ECDSA_SIGN
47a9b3d 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01 eleuzi01 added bug component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Sep 16, 2024
@eleuzi01 eleuzi01 mentioned this pull request Sep 16, 2024
Merged
4 tasks
@eleuzi01
Add PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_IMPORT
db0ed75 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01
Remove some dependencies
6a229f9 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@gilles-peskine-arm gilles-peskine-arm changed the title Fix incorrect dependencies Backport 3.6: Fix incorrect dependencies Sep 18, 2024
gilles-peskine-arm
gilles-peskine-arm approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidhorstmann-arm
davidhorstmann-arm approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 19, 2024
@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Sep 19, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 0417675 Sep 19, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleuzi01 @gilles-peskine-arm @davidhorstmann-arm