Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 3.6: Fixed issue of redefinition warning messages for _GNU_SOURCE #9085

Merged
merged 2 commits into from
May 6, 2024
Merged

Backport 3.6: Fixed issue of redefinition warning messages for _GNU_SOURCE #9085

merged 2 commits into from
May 6, 2024

Conversation

nileshkale123
Copy link
Contributor

@nileshkale123 nileshkale123 commented May 2, 2024 •
edited by tom-cosgrove-arm
Loading

Description

This commit solves the issue of redefinition warning messages for _GNU_SOURCE while building on Linux platform.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@nileshkale123
Fixed issue of redefinition warning messages for _GNU_SOURCE
2a0a628 
Signed-off-by: nilesh.kale <nilesh.kale@espressif.com>
@tom-daubney-arm tom-daubney-arm self-requested a review May 2, 2024 09:26
@tom-daubney-arm tom-daubney-arm added bug needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) component-crypto Crypto primitives and low-level interfaces labels May 2, 2024
@tom-daubney-arm
Copy link
Contributor

Hi @nileshkale123, thanks for putting this up. We have some CI failures here, could you please look into them?

This was referenced May 2, 2024
Merged
Merged
@tom-cosgrove-arm tom-cosgrove-arm self-requested a review May 2, 2024 10:01
@yanesca @nileshkale123
Fix Changelog formatting
7fa3134 
Add EOL and remove trailing whitespaces.

Signed-off-by: Janos Follath <janos.follath@arm.com>
tom-cosgrove-arm
tom-cosgrove-arm approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - faithful backport - I've started the CI on this PR

@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label May 3, 2024
tom-daubney-arm
tom-daubney-arm approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - subject to CI

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels May 3, 2024
@gilles-peskine-arm gilles-peskine-arm changed the title Fixed issue of redefinition warning messages for _GNU_SOURCE Backport 3.6: Fixed issue of redefinition warning messages for _GNU_SOURCE May 6, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue May 6, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit c4f4ff9 May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nileshkale123 @tom-daubney-arm @tom-cosgrove-arm @gilles-peskine-arm @yanesca