Move some scripts to framework submodule #8991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhorstmann-arm
added
needs-review
davidhorstmann-arm
force-pushed
the
move-scripts-to-framework
branch
from
72f1e73 to
53dee4d
Compare
davidhorstmann-arm
changed the title
davidhorstmann-arm
added
needs-ci
davidhorstmann-arm
force-pushed
the
move-scripts-to-framework
branch
2 times, most recently
from
6c74b65 to
43057d0
Compare
davidhorstmann-arm
added
needs-ci
davidhorstmann-arm
force-pushed
the
move-scripts-to-framework
branch
from
93d6b13 to
07033ad
Compare
|
[Force-pushed to update to version of submodule with full history] |
davidhorstmann-arm
added
needs-ci
Ryan-Everett-arm
requested changes
Mar 28, 2024
|
Thanks for catching these, should be addressed now! |
davidhorstmann-arm
added
the
needs-backports
4 tasks
Ryan-Everett-arm
requested changes
Apr 4, 2024
There was a problem hiding this comment.
There are some CI failures in the trivial 3.6 backport (see my comment here). I think that this branch needs to be rebased to pull in the addition of tests/scripts/generate_psa_wrappers.py so that we can change the references to mbedtls_dev in this file, otherwise the merge CI will likely fail.
Signed-off-by: David Horstmann <david.horstmann@arm.com>
Signed-off-by: David Horstmann <david.horstmann@arm.com>
Signed-off-by: David Horstmann <david.horstmann@arm.com>
Signed-off-by: David Horstmann <david.horstmann@arm.com>
Add framework/scripts/*.py to the mypy line in check-python-files.sh For some reason, this allows mypy to find the framework_dev module that resides there, and it does not complain about other scripts. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
force-pushed
the
move-scripts-to-framework
branch
from
0b18008 to
eb6d69f
Compare
davidhorstmann-arm
removed
the
needs-backports
Signed-off-by: David Horstmann <david.horstmann@arm.com>
Specifically: * scripts/code_style.py -> framework/scripts/code_style.py * tests/scripts/audit-validity-dates.py -> framework/scripts/audit-validity-dates.py Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
force-pushed
the
move-scripts-to-framework
branch
from
eb6d69f to
8637a15
Compare
Ryan-Everett-arm
requested changes
Apr 8, 2024
These have been moved to the framework repo. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
removed
the
needs-reviewer
This was referenced Apr 16, 2024
ronald-cron-arm
requested changes
Apr 24, 2024
| @@ -55,14 +55,14 @@ elif [ "$1" = "--can-mypy" ]; then | |||
| fi | |||
|
|
|||
| echo 'Running pylint ...' | |||
| $PYTHON -m pylint scripts/mbedtls_dev/*.py scripts/*.py tests/scripts/*.py || { | |||
| $PYTHON -m pylint framework/scripts/framework_dev/*.py scripts/*.py tests/scripts/*.py || { | |||
There was a problem hiding this comment.
Like in line 65, why not adding framework/scripts/*.py here as well?
| @@ -24,7 +24,7 @@ | |||
| pass | |||
|
|
|||
| import scripts_path # pylint: disable=unused-import | |||
| from mbedtls_dev import build_tree | |||
There was a problem hiding this comment.
This file has to be modified to check the files that are in the framework submodule as well. It seems we just have to change bytes_output = subprocess.check_output(['git', 'ls-files', '-z']) to bytes_output = subprocess.check_output(['git', 'ls-files', '--recurse-submodules', '-z']).
|
Closing as superseded by more separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
code_style.pyand test code generation scripts to the framework submodule.Depends on Mbed-TLS/mbedtls-framework#5
Note: The
frameworksubmodule is updated to the tip of Mbed-TLS/mbedtls-framework#5 to get the CI results. I can rebase this once that PR is merged.PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")