Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS 1.3: Documentation update for 3.6 release #8930

Merged
merged 12 commits into from
Mar 15, 2024
Merged

TLS 1.3: Documentation update for 3.6 release #8930

merged 12 commits into from
Mar 15, 2024

Conversation

ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Mar 15, 2024 •
edited
Loading

Description

Update of TLS 1.3 documentation for 3.6 release
Fixes #8772

PR checklist

  • changelog provided
  • backport not required, no TLS 1.3 support in 2.28
  • tests not required, doc only

@ronald-cron-arm
Add change log for early data feature
e40e42c 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tls13-support.md: Some fixes
124ed8a 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tls13-support.md: Early data supported now
1b606d8 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tls13-support.md: Stop referring to the prototype
d76a2d8 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
docs: Move TLS 1.3 early data doc to a dedicated file
b372b2e 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tls13-early-data.md: Adapt code examples to new coding style
0fce958 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tls13-early-data.md: Fix reading early data documentation
d514d9c 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Document that we do not implement the anti-replay defenses
1987a7c 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review component-tls13 priority-very-high Highest priority - prioritise this over other review work labels Mar 15, 2024
@ronald-cron-arm ronald-cron-arm requested a review from mpg March 15, 2024 09:54
@davidhorstmann-arm davidhorstmann-arm self-requested a review March 15, 2024 10:44
@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Mar 15, 2024
mpg
mpg requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, just a few things.

@ronald-cron-arm
Remove experimental warnings related to early data
933aec8 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm requested a review from mpg March 15, 2024 14:03
@ronald-cron-arm
Copy link
Contributor Author

@mpg many thanks for the review, I believe I have addressed your comments

mpg
mpg previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just thought of one more thing, but not worth doing another round for this if there's nothing else.

davidhorstmann-arm
davidhorstmann-arm requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of wording nits, LGTM otherwise

@ronald-cron-arm
Improve the change log
582865f 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Fix documentation about anti-replay defenses
3996ebc 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Improve tls13-support.md
a9bdc8f 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
davidhorstmann-arm
davidhorstmann-arm approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mpg
mpg approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Mar 15, 2024
@mpg mpg enabled auto-merge March 15, 2024 16:22
@mpg mpg added this pull request to the merge queue Mar 15, 2024
Merged via the queue into Mbed-TLS:development with commit c9db499 Mar 15, 2024
4 of 6 checks passed
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-tls13 enhancement priority-very-high Highest priority - prioritise this over other review work
Projects
No open projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS 1.3 early data wrap-up
3 participants
@ronald-cron-arm @mpg @davidhorstmann-arm