Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS 1.3 ticket and early data unit tests #8711

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Add TLS 1.3 ticket and early data unit tests #8711

merged 10 commits into from
Feb 1, 2024

Conversation

ronald-cron-arm
Copy link
Contributor

Description

Add TLS 1.3 ticket and early data unit tests that aim to be the basis for ticket and early data negative testing in test_suite_ssl.

PR checklist

  • changelog not required, new unit tests only
  • backport not required, no TLS 1.3 support in 2.28
  • tests not required, new unit tests

@ronald-cron-arm ronald-cron-arm force-pushed the tls13-ticket-and-early-data-unit-test branch 9 times, most recently from 5bb025c to 6588011 Compare January 21, 2024 14:23
@ronald-cron-arm
tls13: cli: Fix setting of early data transform
297c608 
Fix setting of early data transform when we
do not send dummy CCS for middlebox compatibility.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
ssl_helpers.c: Add ticket write/parse test functions
77abfe6 
Add ticket write/parse test functions as defined
by mbedtls_ssl_ticket_write/parse_t. They are
intended to be used in negative testing
involving tickets.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tests: tls13: Add session resume with ticket unit test
d903a86 
This aims to provide a basis for negative testing
around TLS 1.3 ticket, replacing eventually the
negative tests done in ssl-opt.sh using the
dummy_ticket option.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tests: ssl: Move setting of debug callback
ec3408d 
Move the setting of the debug callback to
the endpoint initialization function. That
way, no need to repeat it in various testing
scenarios.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tests: tls13: Add early data unit test
a8dd81b 
This aims to provide a basis for negative
testing around TLS 1.3 early data.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
tests: tls13: Run early data test only in TLS 1.3 only config
f8fdbb5 
Temporary workaround to not run the early data test
in Windows-2013 where there is an issue with
mbedtls_vsnprintf().

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm force-pushed the tls13-ticket-and-early-data-unit-test branch from 6588011 to f8fdbb5 Compare January 22, 2024 08:41
@ronald-cron-arm ronald-cron-arm mentioned this pull request Jan 22, 2024
Merged
3 tasks
@ronald-cron-arm ronald-cron-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Jan 22, 2024
This was referenced Jan 26, 2024
Merged
Merged
@tom-cosgrove-arm tom-cosgrove-arm requested a review from mpg January 30, 2024 11:22
@tom-cosgrove-arm tom-cosgrove-arm added priority-very-high Highest priority - prioritise this over other review work and removed needs-reviewer This PR needs someone to pick it up for review labels Jan 30, 2024
mpg
mpg requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, only minor feedback and a couple of questions.

Nice strategy, I like how you're taking advantage of mbedtls_test_move_handshake_to_state() - bit of a hack, but perfect for testing.

@ronald-cron-arm
Explain purpose of test specific write/parse ticket functions
faf026c 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Fix PSA init and done macros in TLS unit tests
095a3a5 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Fix and add comments in ticket and early data test function
5de9c6f 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Use TEST_EQUAL instead of TEST_ASSERT where possible
eb84534 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm requested a review from mpg January 31, 2024 20:00
mpg
mpg approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback, looks all good to me now!

waleed-elmelegy-arm
waleed-elmelegy-arm approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@waleed-elmelegy-arm waleed-elmelegy-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Feb 1, 2024
Merged via the queue into Mbed-TLS:development with commit 11cc412 Feb 1, 2024
6 checks passed
@ronald-cron-arm ronald-cron-arm mentioned this pull request Feb 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@waleed-elmelegy-arm waleed-elmelegy-arm waleed-elmelegy-arm approved these changes

Assignees
No one assigned
Labels
component-tls13 enhancement needs-review Every commit must be reviewed by at least two team members, priority-very-high Highest priority - prioritise this over other review work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronald-cron-arm @mpg @waleed-elmelegy-arm @tom-cosgrove-arm