Fix TLS pad buffer zeroization #8068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
paul-elliott-arm
added
needs-review
paul-elliott-arm
changed the title
tom-cosgrove-arm
added
approved
daverodgman
removed
the
single-reviewer
daverodgman
requested changes
Aug 14, 2023
| @@ -0,0 +1,3 @@ | |||
| Bugfix | |||
| * Fix a case where potentially sensitive information would not be completely | |||
| zeroized during TLS handshake. | |||
There was a problem hiding this comment.
Can we be more specific about the affected scenarios? E.g., is it 1.2 only, is it only for certain key exchanges, etc etc?
There was a problem hiding this comment.
I have tried to be specific as I can be - yes this is TLS1.2 only, but its not dependant on hash used, all paths lead to this.
gilles-peskine-arm
removed
the
approved
3 tasks
paul-elliott-arm
force-pushed
the
fix_tls_zeroization
branch
from
26c8730 to
d00a3fa
Compare
paul-elliott-arm
changed the title
daverodgman
requested changes
Sep 1, 2023
| @@ -0,0 +1,3 @@ | |||
| Bugfix | |||
There was a problem hiding this comment.
I think this should be Security not Bugfix
Suggested change
| Bugfix | |
| Security |
| @@ -0,0 +1,3 @@ | |||
| Bugfix | |||
| * Fix a case where potentially sensitive information would not be completely | |||
| zeroized during TLS 1.2 handshake, in both server and client configuration. | |||
There was a problem hiding this comment.
(1) this should be Security
(2) this should mention "in memory" as it's user-facing: it could be possible to interpret this as some old data leaking into a message on the wire "during TLS 1.2 handshake"
|
@paul-elliott-arm this still needs a Changelog update? |
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
paul-elliott-arm
force-pushed
the
fix_tls_zeroization
branch
from
d00a3fa to
83ae22d
Compare
Sorry, moving too fast and forgot to amend the actual changes. |
daverodgman
approved these changes
Sep 1, 2023
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue whereby the pad buffer was not completely zeroized in some cases during TLS handshake.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
, or not requireddone, ornot required - code does not exist in 2.28provided, ornot required - not something that is easily testable, XXX err, actually see Check mbedtls_platform_zeroize() calls #8143