Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix empty union when TLS is disabled #7987

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Backport 2.28: Fix empty union when TLS is disabled #7987

merged 1 commit into from
Jul 27, 2023

Conversation

gilles-peskine-arm
Copy link
Contributor

Trivial backport of #7835

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@gilles-peskine-arm
Fix empty union when TLS is disabled
e5507d5 
When all TLS 1.2 support is disabled, union mbedtls_ssl_premaster_secret was
empty, which is not valid C even if the union is never used. Fixes Mbed-TLS#6628.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added bug component-tls needs-ci Needs to pass CI tests single-reviewer This PR qualifies for having only one reviewer priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jul 26, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added the approved Design and code approved - may be waiting for CI or backports label Jul 26, 2023
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jul 26, 2023
Merged
3 tasks
@gilles-peskine-arm gilles-peskine-arm merged commit ae68c09 into Mbed-TLS:mbedtls-2.28 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-tls needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilles-peskine-arm @tom-cosgrove-arm