Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass pk_context pointer to PK wrappers instead of void pointer #7463

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Pass pk_context pointer to PK wrappers instead of void pointer #7463

merged 1 commit into from
Apr 24, 2023

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Apr 20, 2023 •
edited by minosgalanakis
Loading

This PR addresses the 2nd point of #7460
Resolves #7460

Gatekeeper checklist

  • changelog not required
  • backport not required
  • tests not required

@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Apr 20, 2023
@valeriosetti valeriosetti requested a review from mpg April 20, 2023 08:03
@valeriosetti valeriosetti self-assigned this Apr 20, 2023
@valeriosetti valeriosetti mentioned this pull request Apr 20, 2023
Closed
3 tasks
@valeriosetti
pk: pass pk_context pointer to wrappers intead of void one
38992cb 
Signed-off-by: valerio <valerio.setti@nordicsemi.no>
mpg
mpg approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriosetti valeriosetti removed the needs-ci Needs to pass CI tests label Apr 20, 2023
@valeriosetti valeriosetti mentioned this pull request Apr 20, 2023
Merged
3 tasks
@AndrzejKurek AndrzejKurek self-requested a review April 24, 2023 14:27
@AndrzejKurek AndrzejKurek removed the needs-reviewer This PR needs someone to pick it up for review label Apr 24, 2023
AndrzejKurek
AndrzejKurek approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@AndrzejKurek AndrzejKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With such scope of the PR I'm happy if the CI is happy :)

@AndrzejKurek AndrzejKurek added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 24, 2023
@AndrzejKurek
Copy link
Contributor

It seems that neither our internal nor the OpenCI merge runs were succesfull, so I'm not sure if the head testing is enough to assume that the CI is happy.

@gilles-peskine-arm
Copy link
Contributor

The merge job only runs the API/ABI/storage-format/driver-test-equivalence checks nowadays. This PR doesn't change any public header or test dependencies, so the API/… checks would obviously pass anyway (barring a test glitch).

@gilles-peskine-arm gilles-peskine-arm merged commit ad450d5 into Mbed-TLS:development Apr 24, 2023
@Skptak Skptak mentioned this pull request Dec 11, 2023
Merged
2 tasks
@valeriosetti valeriosetti deleted the issue7460-part2 branch December 6, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

Assignees

@valeriosetti valeriosetti

Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve pk_wrap calling convention and check for remaning ECP dependencies in PK files
4 participants
@valeriosetti @AndrzejKurek @gilles-peskine-arm @mpg