Add milliseconds platform time function #6891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhaoth
added
needs-review
5 tasks
From RFC8446, the unit of ticket age is million seconds Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
We provide windows and posix implementation for it. With MBEDTLS_PLATFORM_MS_TIME_ALT, user can provide their own implementation. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/add-milliseconds-platform-function
branch
from
294829a to
3825749
Compare
yuhaoth
force-pushed
the
pr/add-milliseconds-platform-function
branch
2 times, most recently
from
e609641 to
fec8ff2
Compare
There's a potential race condition with calling time(NULL) after GetSystemTime(). See https://learn.microsoft.com/en-us/archive/msdn-magazine/2004/march/implementing-a-high-resolution-time-provider-for-windows Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/add-milliseconds-platform-function
branch
from
fec8ff2 to
947fd3d
Compare
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/add-milliseconds-platform-function
branch
from
b381988 to
eb30684
Compare
|
Internal CI pass and OpenCI report docker build fail |
|
Now, CI passed |
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/add-milliseconds-platform-function
branch
from
49ba576 to
041c8c1
Compare
We need a non-settable source to avoid security issues. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/add-milliseconds-platform-function
branch
from
884a8b0 to
02d6840
Compare
|
@tom-cosgrove-arm , I just re-write the commit history due to the CI fails. Sorry for that. |
|
Removed |
`GetSystemTimeAsFileTime` returns 100 nano seconds elapsed time, not 100 micro seconds. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
|
@tom-cosgrove-arm , just fix windows fail. Please re-review |
|
@daverodgman and @gilles-peskine-arm are either of you two reviewing this, or should I add |
I will TAL |
|
I'm not reviewing. |
tom-cosgrove-arm
added
the
needs-reviewer
daverodgman
approved these changes
Mar 29, 2023
daverodgman
added
approved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #6623.
This PR provide milliseconds platform time function to resolve ticket age issue.
The time unit of ticket age is milliseconds and the unit in current code is seconds. That causes client age is bigger that server age, it is identified as replay attack. For a final solution, we need milliseconds function.
mbedtls_ms_timeis used in #6788 , that has been verified.Gatekeeper checklist