TLS 1.3: Reproduce and fix anti replay fail #6712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
5 times, most recently
from
8de6b84 to
77a50b6
Compare
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Dec 15, 2022
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this commit can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
3 tasks
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
from
77a50b6 to
42081df
Compare
5 tasks
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
from
42081df to
c8ace54
Compare
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Dec 15, 2022
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this commit can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Dec 15, 2022
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this commit can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
2 times, most recently
from
34e96ef to
c5c9113
Compare
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Dec 16, 2022
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this commit can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Dec 17, 2022
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
|
The solution has been verified |
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Dec 18, 2022
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Jan 3, 2023
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Jan 7, 2023
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Jan 7, 2023
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
|
Reopen to verify commit |
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
from
c5c9113 to
1f4f7a7
Compare
This reverts commit 4e83173. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Filter tests base on TEST_SUITE_NAME Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
- Improve test speed. we do not need 2 seconds delay - Adjust reco_delay time to improve fail raite. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
from https://jenkins-mbedtls.oss.arm.com/blue/rest/organizations/jenkins/pipelines/mbed-tls-pr-merge/branches/PR-6712-merge/runs/8/nodes/449/steps/4945/log/?start=0 Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
2 times, most recently
from
ebe352f to
404cc87
Compare
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
tests/reproduce-fix-anti_replay_fail
branch
from
404cc87 to
5b3790a
Compare
|
The workaround solution has been verified. Close this PR |
AndrzejKurek
pushed a commit
to AndrzejKurek/mbedtls
that referenced
this pull request
Jan 17, 2023
Per gnutls anti replay issue, it needs millionsecond time delay for improve the fail rate. From test result of Mbed-TLS#6712, this can improve the fail rate from 4% to 92%. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #6623
TLS 1.3 m->G: EarlyData: basic check, good.That try to reproduce the issue as quick as possible. According to previous experience, the issue might appear about 1 times per 100 times. With the script, I found the fail rate is about 4% in my local test, so I add a 400 times loop.
To reproduce locally, just call
ssl-opt.sh, I have changessl-opt.shto run only the test case for 400 times.Future topic
Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.