Backport 2.28: check_names: extend typo check to PSA macro/enum names #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typos of PSA macro and enum names are not checked by check_names.py. This commit extend the check list to include PSA_XXX references. The words should be macro/enum names defined as public_macros, internal_macros, private_macros and enums. This commit also extend the scope of enums to include those are defined in library/*.c. A new type of macros "private", which are defined in library/*.c was also added. Signed-off-by: Pengyu Lv <pengyu.lv@arm.com>
This macro is expected to be defined out of the library, and there is no definition in the library. Thus it needs to be excluded from typo check. Signed-off-by: Pengyu Lv <pengyu.lv@arm.com>
Fix the PSA_XXX typos detected by check_names.py. Signed-off-by: Pengyu Lv <pengyu.lv@arm.com>
lpy4105
added
enhancement
needs-review
|
Internal CI pass |
4 tasks
AndrzejKurek
approved these changes
Nov 23, 2022
|
Backport looks good, original PR has one suggested improvement. |
AndrzejKurek
removed
the
needs-reviewer
yuhaoth
added
the
approved
mpg
added
needs-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a backport of #6558 to branch mbedtls-2.28 which resolves the issue #6416.