Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS 1.3: EarlyData: SRV: Implement mbedtls_ssl_read_early_data #6541

Closed
wants to merge 8 commits into from
Closed

TLS 1.3: EarlyData: SRV: Implement mbedtls_ssl_read_early_data #6541

wants to merge 8 commits into from

Conversation

yuhaoth
Copy link
Contributor

@yuhaoth yuhaoth commented Nov 5, 2022 •
edited
Loading

Description

fix #6341

  • Implement mbedtls_ssl_read_early_data
  • Add tests for read early_data

Gatekeeper checklist

  • changelog not required( That part of tls13 early data)
  • backport not required( That part of tls13 early data)
  • tests provided(That has been covered by exist tests)

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@yuhaoth yuhaoth added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review component-tls13 labels Nov 5, 2022
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch from 04d9607 to 23c2c51 Compare November 5, 2022 16:14
@yuhaoth yuhaoth changed the title Pr/tls13 add early data support of server side TLS 1.3: EealyData: Add basic flow support. Nov 6, 2022
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch 4 times, most recently from 8feb8a5 to 6533f18 Compare November 7, 2022 06:31
@yuhaoth yuhaoth mentioned this pull request Nov 7, 2022
Closed
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch 9 times, most recently from 9a78290 to ac96ad6 Compare November 11, 2022 13:08
@yuhaoth yuhaoth changed the title TLS 1.3: EealyData: Add basic flow support. TLS 1.3: EealyData: SRV: Add basic flow support. Nov 12, 2022
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch 3 times, most recently from d7742b5 to 3cea3f3 Compare November 16, 2022 10:51
@daverodgman daverodgman changed the title TLS 1.3: EealyData: SRV: Add basic flow support. TLS 1.3: EarlyData: SRV: Add basic flow support. Nov 16, 2022
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch 4 times, most recently from d711fcb to cb66258 Compare November 18, 2022 05:22
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch 2 times, most recently from 893af4c to 9cf4e68 Compare December 6, 2023 10:09
@yuhaoth yuhaoth added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests and removed needs-work needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first historical-reviewed Reviewed & agreed to keep legacy PR/issue labels Dec 6, 2023
@yuhaoth
Add mbedtls_ssl_assert macro
b290aab 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
Add shared internal function mbedtls_ssl_read_inmsg
e1b53e3 
The code will be shared between `mbedtls_ssl_read` and
`mbedtls_ssl_read_early_data`

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
move early data size check tag
18008ab 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
implement mbedtls_ssl_read_early_data()
4472d4d 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
Add read early data support for ssl_server2.
57d7bcb 
See ./docs/architecture/tls13-support.md

The logic followup the description in above document.

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
Add has_early_data error return
8b181ba 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
add has early data into in_progress list
5da4e74 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
update early data test
4561c4d 
make sure the data is not printed in
library.

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth yuhaoth force-pushed the pr/tls13-Add-early_data-support-of-server-side branch from 9cf4e68 to 4561c4d Compare December 8, 2023 09:37
@tom-cosgrove-arm tom-cosgrove-arm added priority-high High priority - will be reviewed soon and removed priority-very-high Highest priority - prioritise this over other review work labels Dec 13, 2023
@ronald-cron-arm ronald-cron-arm mentioned this pull request Jan 10, 2024
Merged
3 tasks
@ronald-cron-arm ronald-cron-arm removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon labels Jan 15, 2024
@ronald-cron-arm
Copy link
Contributor

Superseded by #8692.

@ronald-cron-arm ronald-cron-arm removed their request for review January 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component-tls13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS 1.3 server: Add support for early data reading
4 participants
@yuhaoth @tom-daubney-arm @ronald-cron-arm @tom-cosgrove-arm