Add initialization for structures in test #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
gabor-mezei-arm
added
bug
needs-ci
gilles-peskine-arm
requested changes
Sep 23, 2022
There was a problem hiding this comment.
Whether initialization is required for the test program to be correct C depends on the exact order in which the function performs its initial checks. The test code shouldn't depend on that, so it should initialize everything.
2.28 has similar issues in some of its invalid_param tests. There the issue is also present in test_suite_ecdsa. On the other hand, test_suite_rsa is fine.
gilles-peskine-arm
added
needs-work
needs-backports
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
gabor-mezei-arm
added
needs-review
wernerlewis
added
approved
gilles-peskine-arm
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing initialization that cause build error.
Fix #6308
Requires Backporting