Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid conversion #472

Closed
wants to merge 1 commit into from
Closed

Fix invalid conversion #472

wants to merge 1 commit into from

Conversation

davidgatti
Copy link

Added this cast since without it the compiler for Particle.io will throw the following error: invalid conversion from 'void_' to 'volatile unsigned char_'. I hope this helps :)

Added this cast since without it the compiler for Particle.io will throw the following error: invalid conversion from 'void*' to 'volatile unsigned char*'. I hope this helps :)
@jcowgill
Copy link
Contributor

jcowgill commented May 7, 2016

void * to volatile unsigned char * is a perfectly acceptable conversion in C. Are you using a C++ compiler instead?

@davidgatti
Copy link
Author

http://particle.io does. I'm not compiling this code locally. The code is compiled remotely on their servers.

@simonbutcher
Copy link
Contributor

Hi,

I understand from @pjbakker that we used to compile cleanly using C++ compilers, but this doesn't appear to be the case at the moment. I've raised an issue #477 to track the issue and we'll look into it in case there are any other problems in other configurations.

Thanks for the pull request. I appreciate the fix is trivial, but unfortunately, to accept the contribution and any future contribution we will need a Contributor’s Licence Agreement (CLA) signed by yourself or by whoever has the authority to do so. You can find an agreement to sign here, which can be signed and returned to us, or you could create an mbed account and accept a slightly different agreement here with a click through if this is a personal contribution, which should be simple and quick.

Thanks in advance for your understanding.

@simonbutcher
Copy link
Contributor

Hi,

I tried compiling mbed TLS with g++, and found there were numerous errors in different zeroize functions, so rather than merge the pull request, I fixed them all in one go in commit 88ffc08.

This pull request can now be closed, although there are still too many errors to be able to close #477.

Thanks again for the support of the project!

@davidgatti davidgatti deleted the patch-1 branch May 24, 2016 08:26
iameli pushed a commit to livepeer/mbedtls that referenced this pull request Dec 5, 2023
…nd-android

Add ci builds for ios and android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants