Update return code for various key operations #4189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update psa_destroy_key and other key operations to return PSA_ERROR_INVALID_HANDLE where appropriate, rather than PSA_ERROR_DOES_NOT_EXIST. Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
daverodgman
added
bug
component-psa
Summer-ARM
reviewed
Mar 4, 2021
| * | ||
| * \retval #PSA_SUCCESS | ||
| * \retval #PSA_ERROR_INVALID_HANDLE |
There was a problem hiding this comment.
sorry, do I miss something? didn't see this return value in the function implementation.
stevew817
reviewed
Mar 4, 2021
| @@ -3364,6 +3369,11 @@ psa_status_t psa_sign_hash( mbedtls_svc_key_id_t key, | |||
| status = psa_get_and_lock_key_slot_with_policy( key, &slot, | |||
| PSA_KEY_USAGE_SIGN_HASH, | |||
| alg ); | |||
| /* Return invalid handle as per PSA API 1.0.0 if trying to copy persistent | |||
There was a problem hiding this comment.
You're not trying to copy a key here...
|
This PR is superseded by #4198. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update psa_destroy_key and other key operations to return
PSA_ERROR_INVALID_HANDLE where appropriate, rather than
PSA_ERROR_DOES_NOT_EXIST.
Fixes #4162
Signed-off-by: Dave Rodgman dave.rodgman@arm.com