Tweak documentation about lifetimes #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
In the documentation of lifetimes, replace language meant for the PSA specification by language that is specifically about Mbed TLS. Reduce the discussion of what could happen in other implementation, and discuss what can and cannot happen in integrations of Mbed TLS. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
enhancement
needs-review
|
Added the "needs: work" label as I have pending questions. |
daverodgman
added
the
needs-reviewer
mpg
requested changes
Dec 11, 2020
There was a problem hiding this comment.
I'm mostly happy with this PR, except for a couple of small things already pointed by Ronald.
Also, I noticed that looking for [Ii]mplementations finds many occurrences, which should probably be changed too, but perhaps that's out of scope of this PR if you want to keep it focused on lifetimes.
mpg
removed
the
needs-review
It's about who has access to the key material in plaintext, not directly where the operation is performed. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Some of the material was originally the PSA specification, and discusses how different implementations might behave. Replace such statements by a description of how Mbed TLS behaves. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
needs-review
ronald-cron-arm
requested changes
Dec 14, 2020
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
ronald-cron-arm
approved these changes
Dec 14, 2020
mpg
removed
the
needs-review
|
The CI failure in the pr-merge job on Windows is an unrelated issue with the infrastructure and can be ignored for the purposed of merging this PR. |
mpg
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3302. No behavior change, just documentation improvements.