Fix type conversion bug in ssl_context_info example program.
#3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2020 10:52
Previously, the return value from `fgetc()` was immediately converted to `char` and then compared to `EOF`. This doesn't work since `EOF` is a special value outside of the range of `char` (when embedded in `int`). This commit fixes the code to store the result of `fgetc()` as an `int`, compare to `EOF`, and only on mismatch convert it to `char` for further processing. Signed-off-by: Hanno Becker <hanno.becker@arm.com>
Signed-off-by: Hanno Becker <hanno.becker@arm.com>
hanno-becker
added
bug
mbed TLS team
needs-review
|
Yes, at the time of opening this PR, #3449 had a wider scope, which by now has been reduced to the correction of |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some code in
programs/ssl/ssl_context_info.cconverted the return value fromfgetc()tocharimmediately, and then compared it toEOF. This doesn't work sinceEOFis a special value outside of the range ofchar(when embedded inint).The PR fixes the code to store the result of
fgetc()as anint, compare toEOF, and only on mismatch convert it tocharfor further processing.Status
READY
Requires Backporting
NO