Fix "same actions in two cases of a switch statement" warning #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Mbed-TLS#3202 Signed-off-by: irwir <irwir@users.noreply.github.com>
|
In the commit message, it would be helpful if you stated what compiler and version you get this warning with. |
danh-arm
added
needs-review
Warnings of this particular kind mostly come from static analysis. |
gilles-peskine-arm
approved these changes
Apr 21, 2020
gilles-peskine-arm
removed
the
needs-review
|
There was a glitch on the CI, but only in the result analysis phase which doesn't impact the testing of the new code. Mbed OS CI is currently not operational. So the CI can be considered to have passed. |
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this pull request
Apr 21, 2020
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove duplication and use multiple case labels for the action.
Resolves #3202
Status
READY
Requires Backporting
NO
Which branch?
development
Migrations
NO