Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_suite_md in mbedtls_md_process() violates the md API #2227

Closed
RonEld opened this issue Nov 25, 2018 · 1 comment · Fixed by #2229
Closed

test_suite_md in mbedtls_md_process() violates the md API #2227

RonEld opened this issue Nov 25, 2018 · 1 comment · Fixed by #2229
Labels
bug component-crypto Crypto primitives and low-level interfaces

Comments

@RonEld
Copy link
Contributor

RonEld commented Nov 25, 2018 •
edited
Loading

Description

  • Type: Bug
  • Priority: Major

As discussed in ARMmbed/mbed-os#8728 (comment) , the test violates the API as it should call mbedtls_md_starts()
This could cause failures in HW accelerations.

Bug

OS
Mbed OS|linux|windows

mbed TLS build:
Version:2.13.0

Expected behavior
test suite md to call mbedtls_md_starts() before any other calls.

Actual behavior
In the test mbedtls_md_process(), mbedtls_md_starts() is not called.
Steps to reproduce
Run the features-mbedtls-tests-mbedtls-test_suite_md On target test on NRF52840_DK and there will be a crash.
@RonEld RonEld added bug needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces labels Nov 25, 2018
@RonEld RonEld mentioned this issue Nov 25, 2018
Merged
@RonEld RonEld added tracking and removed needs-review Every commit must be reviewed by at least two team members, labels Nov 25, 2018
RonEld pushed a commit to RonEld/mbedtls that referenced this issue Nov 25, 2018
Fix test_suite_md API violation
e491374 
Add a call to `mbedtls_md_starts()` in the `mbedtls_md_process()`
test, as it violates the API usage. Fixes Mbed-TLS#2227.
@RonEld RonEld mentioned this issue Nov 25, 2018
Merged
4 tasks
@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2641

tom-cosgrove-arm pushed a commit to tom-cosgrove-arm/mbedtls that referenced this issue Mar 4, 2022
@tom-cosgrove-arm
Fix test_suite_md API violation
1b31faf 
Add a call to `mbedtls_md_starts()` in the `mbedtls_md_process()`
test, as it violates the API usage. Fixes Mbed-TLS#2227.
tom-cosgrove-arm pushed a commit to tom-cosgrove-arm/mbedtls that referenced this issue Mar 4, 2022
@tom-cosgrove-arm
Fix test_suite_md API violation
b6889d1 
Add a call to `mbedtls_md_starts()` in the `mbedtls_md_process()`
test, as it violates the API usage. Fixes Mbed-TLS#2227.

Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
tom-cosgrove-arm pushed a commit to RonEld/mbedtls that referenced this issue Mar 4, 2022
@tom-cosgrove-arm
Fix test_suite_md API violation
0df1ecd 
Add a call to `mbedtls_md_starts()` in the `mbedtls_md_process()`
test, as it violates the API usage. Fixes Mbed-TLS#2227.

Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-crypto Crypto primitives and low-level interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test md api violation RonEld/mbedtls
2 participants
@ciarmcom @RonEld