Replace MBEDTLS_MD_CAN_SHA256 with PSA_WANT_ALG_SHA_256 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleuzi01
added
enhancement
4 tasks
tom-daubney-arm
removed
the
needs-reviewer
tom-daubney-arm
added
approved
scripts/generate_pkcs7_tests.py
Outdated
| @@ -37,7 +37,7 @@ class TestData: | |||
| Take in test_suite_pkcs7.data file. | |||
| Allow for new tests to be added. | |||
| """ | |||
| mandatory_dep = "MBEDTLS_MD_CAN_SHA256" | |||
| mandatory_dep = "PSA_WANT_ALG_SHA_256" | |||
There was a problem hiding this comment.
This looks right for 4.0, but doesn't it break 3.6? In the framework, we'll need to have dependencies that are conditional on the version.
gilles-peskine-arm
requested changes
Jul 11, 2024
gilles-peskine-arm
added
needs-ci
6 tasks
This was referenced Sep 25, 2024
eleuzi01
dismissed stale reviews from tom-daubney-arm and gabor-mezei-arm
via
60b91ab
scripts/generate_pkcs7_tests.py
Outdated
| @@ -37,7 +38,13 @@ class TestData: | |||
| Take in test_suite_pkcs7.data file. | |||
| Allow for new tests to be added. | |||
| """ | |||
| mandatory_dep = "PSA_WANT_ALG_SHA_256" | |||
|
|
|||
| #temporary solution to determine correct dependency macrosbetween 3.6 and 4.0 | |||
There was a problem hiding this comment.
missing space between macros and between
There was a problem hiding this comment.
Otherwise please reference the issue #51 and probably better to rebase your two commits on top of main.
eleuzi01
force-pushed
the
replace-mbedtls-md-can-sha256
branch
from
60b91ab to
21e7eed
Compare
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Temporary solution to be resolved in Mbed-TLS#51. Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
eleuzi01
force-pushed
the
replace-mbedtls-md-can-sha256
branch
from
21e7eed to
c911c34
Compare
eleuzi01
added
needs-review
| @@ -37,7 +38,14 @@ class TestData: | |||
| Take in test_suite_pkcs7.data file. | |||
| Allow for new tests to be added. | |||
| """ | |||
| mandatory_dep = "MBEDTLS_MD_CAN_SHA256" | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
nit, unnecessary blank line
|
Moved changes to PR #34, therefore closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9112 in mbedtls
Part of #9173