Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generation of PSA test wrappers for PAKE #22

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix generation of PSA test wrappers for PAKE #22

merged 1 commit into from
Jun 19, 2024

Conversation

ronald-cron-arm
Copy link
Contributor

Associated to Mbed-TLS/mbedtls#9185

@ronald-cron-arm ronald-cron-arm mentioned this pull request Jun 4, 2024
Merged
4 tasks
davidhorstmann-arm
davidhorstmann-arm approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm
Copy link
Contributor

davidhorstmann-arm commented Jun 12, 2024 •
edited
Loading

Looks like this will need a force-push to retrigger DCO:

git commit --amend --no-edit
git push --force-with-lease

@ronald-cron-arm ronald-cron-arm deleted the fix-generation-of-psa-test-wrappers branch June 13, 2024 10:09
@ronald-cron-arm ronald-cron-arm restored the fix-generation-of-psa-test-wrappers branch June 13, 2024 10:11
@ronald-cron-arm ronald-cron-arm force-pushed the fix-generation-of-psa-test-wrappers branch from 353f714 to c3d2f01 Compare June 13, 2024 10:13
@ronald-cron-arm
Copy link
Contributor Author

Looks like this will need a force-push to retrigger DCO:

git commit --amend --no-edit
git push --force-with-lease

Fixed.

tom-daubney-arm
tom-daubney-arm approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@tom-daubney-arm tom-daubney-arm added the approved Design and code approved - may be waiting for CI or backports label Jun 13, 2024
@ronald-cron-arm
Fix generation of PSA test wrappers for PAKE
b332327 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm ronald-cron-arm force-pushed the fix-generation-of-psa-test-wrappers branch from c3d2f01 to b332327 Compare June 19, 2024 07:22
@tom-daubney-arm
Copy link
Contributor

Just confirming my approval for the PR given the updates: LGTM.

davidhorstmann-arm
davidhorstmann-arm approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for new changes as well

@ronald-cron-arm
Copy link
Contributor Author

Validated for development with PR 9185 CI, for 3.6 with PR 9289 CI, 2 approvals, thus merging.

@ronald-cron-arm ronald-cron-arm merged commit 0484721 into Mbed-TLS:main Jun 19, 2024
1 check passed
@minosgalanakis minosgalanakis mentioned this pull request Jun 20, 2024
Merged
@ronald-cron-arm ronald-cron-arm mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronald-cron-arm @davidhorstmann-arm @tom-daubney-arm