-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Framework] Move test_psa_*.py scripts to the framework #132
[Framework] Move test_psa_*.py scripts to the framework #132
Conversation
Running `make library/foo`, `make programs/foo` or `make tests/foo` only rebuilt the given target if it was not an existing file, because the toplevel makefile does not know the file's dependencies and thus thought that every such target had empty dependencies. Fix this by always invoking make recursively. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Remove all code guarded by `PSA_WANT_ECC_SECP_K1_224`, which is not and will not be implemented. (It would be K1_225 anyway, but we don't intend to implement it anyway.) Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Update TF-PSA-Crypto to have the latest framework with Mbed-TLS#83 . Update the framework to match. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
…es-never-supported-positive-dev Switch generate_psa_test.py to automatic dependencies for positive test cases
The following files are moved to the framework repo (deleted here): tests/scripts/check_names.py Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Move tests/scripts/check_names.py to the framework
The following files are moved to the framework repo (deleted here): scripts/min_requirements.py Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
This call into the "old" script that has been moved to the framework repository. The *.requirements.txt files are kept on this repo though. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Move most of min_requirements.py to the framework
The following files are moved to the framework repo (deleted here): tests/scripts/pkgconfig.sh Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
The script was moved to the framework sub-repo. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Move pkgconfig.sh to the framework
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
This dependency was never right in the first place. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
This commit removes the check_test_dependencies from Mbed TLS as it has been added to TF-PSA-Crypto. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit updates TF-PSA-Crypto pointer to include the moved test in Mbed TLS via TF-PSA-Crypto. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit updates the framework pointer to include modified collect_test_cases.py which can run independently for TF-PSA-Crypto. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
Remove deprecated function mbedtls_x509write_crt_set_serial()
Affected files are: - test_psa_compliance.py - test_psa_constant_names.py Signed-off-by: Valerio Setti <vsetti@baylibre.com>
0061c9d
to
3399879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks almost good to me but one pre-existing condition that I'd like to improve.
3399879
to
291802b
Compare
The script had small differences between the development branch and the mbedtls-3.6 ones. The goal of this commit is to reconcile those differences in order to make it usable from both branches. This is necessary now that the scripts lives in the framework repo. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
291802b
to
9d3a144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment in check-python-files.sh that would be nicer to update:
# tests/scripts/test_psa_constant_names.py:34: error: Cannot find implementation or library stub for module named 'mbedtls_framework'
Update the path of the file now that it has been moved to the framework repo. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validated by the CI of Mbed-TLS/mbedtls#9940 (dev) and Mbed-TLS/mbedtls#9941 (3.6). |
Description
This is the
framework
part of Mbed-TLS/mbedtls#9940PR checklist