Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code style check #48

Open
ronald-cron-arm opened this issue Sep 22, 2023 · 1 comment · May be fixed by #93 or #201
Open

Add code style check #48

ronald-cron-arm opened this issue Sep 22, 2023 · 1 comment · May be fixed by #93 or #201
Assignees
@ronald-cron-arm
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@ronald-cron-arm
Copy link
Contributor

ronald-cron-arm commented Sep 22, 2023 •
edited
Loading

Add code style check

  • [] Adapt code_style.py to work both for mbedtls and TF-PSA-Crypto repo. Keep check of all files when called in the context of mbedtls for the time being.
  • [] Add tf_psa_crypto_check_code_style component in tf-psa-crypto/tests/scripts/components-basic-checks.sh (to be created).

Depends on: Mbed-TLS/mbedtls#9720 and #50 (code_style.py parses check-generated-files.sh).

DOD: Same support for code style checking in TF-PSA-Crypto as in mbedtls
@ronald-cron-arm ronald-cron-arm added enhancement New feature or request size-s Estimated task size: small (~2d) labels Sep 22, 2023
@tom-daubney-arm tom-daubney-arm self-assigned this Nov 7, 2023
@ronald-cron-arm ronald-cron-arm mentioned this issue Nov 9, 2023
Closed
@tom-daubney-arm tom-daubney-arm linked a pull request Dec 6, 2023 that will close this issue
Open
@ronald-cron-arm ronald-cron-arm linked a pull request Dec 6, 2023 that will close this issue
Add code style check #93
Open
@ronald-cron-arm ronald-cron-arm mentioned this issue May 7, 2024
Closed
@github-project-automation github-project-automation bot moved this to PSA repo Q4 - all.sh components in Backlog for Mbed TLS Aug 30, 2024
@mpg mpg mentioned this issue Oct 3, 2024
Closed
@ronald-cron-arm ronald-cron-arm moved this to TF-PSA-Crypto all.sh components in Mbed TLS Epics Nov 4, 2024
@mpg mpg mentioned this issue Nov 14, 2024
Closed
@Harry-Ramsey
Copy link
Contributor

Harry-Ramsey commented Dec 27, 2024 •
edited
Loading

Upon investigation, this task just requires check-generated-files.sh to be moved to framework/scripts. It does report numerous code issues however for TF-PSA-Crypto which will need to be fixed or the code style may need to be adjusted for TF-PSA-Crypto.

Currently an if statement like this is invalid:

if (ret != 0)
    return P256_INVALID_PRIVKEY;

and needs to be replaced with

if (ret != 0) {
    return P256_INVALID_PRIVKEY;
}

@ronald-cron-arm ronald-cron-arm moved this from TF-PSA-Crypto all.sh components to TF-PSA-Crypto all.sh basic-checks in Mbed TLS Epics Jan 6, 2025
@Harry-Ramsey Harry-Ramsey removed their assignment Jan 20, 2025
@ronald-cron-arm ronald-cron-arm self-assigned this Feb 11, 2025
@ronald-cron-arm ronald-cron-arm linked a pull request Mar 13, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronald-cron-arm ronald-cron-arm

Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Mbed TLS Epics
Status: TF-PSA-Crypto all.sh 1 - basic-checks
Milestone
No milestone
3 participants
@ronald-cron-arm @tom-daubney-arm @Harry-Ramsey