-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make db port configurable via POSTGRES_PORT
#2751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
37f93c6
to
497f0ce
Compare
Signed-off-by: merobi-hub <merobi@gmail.com>
651b9d4
to
982009f
Compare
POSTGRES_PORT
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
============================================
+ Coverage 80.63% 84.45% +3.82%
- Complexity 234 1416 +1182
============================================
Files 43 251 +208
Lines 976 6447 +5471
Branches 38 291 +253
============================================
+ Hits 787 5445 +4658
- Misses 160 850 +690
- Partials 29 152 +123 ☔ View full report in Codecov by Sentry. |
ff2d297
to
8aa50d6
Compare
Signed-off-by: merobi-hub <merobi@gmail.com>
8aa50d6
to
c5ddd98
Compare
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
wslulciuc
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
366a412
to
f1e269b
Compare
Signed-off-by: merobi-hub <merobi@gmail.com>
f1e269b
to
15f3f5b
Compare
Signed-off-by: merobi-hub <merobi@gmail.com>
jonathanpmoraes
pushed a commit
to nubank/NuMarquez
that referenced
this pull request
Feb 6, 2025
* Make db port configurable via new env var. Signed-off-by: merobi-hub <merobi@gmail.com> * Add DB_PORT env var to .env.example. Signed-off-by: merobi-hub <merobi@gmail.com> * Fix entrypoint. Signed-off-by: merobi-hub <merobi@gmail.com> * Add db port to ci env. Signed-off-by: merobi-hub <merobi@gmail.com> * Add pg port param to up script. Signed-off-by: merobi-hub <merobi@gmail.com> --------- Signed-off-by: merobi-hub <merobi@gmail.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, changing the db port requires modifying several different yml files in the project related to the Docker configuration.
Solution
This makes configuring the db port more developer-friendly by replacing the db port assignments with the existing env var,
POSTGRES_PORT
. It is given a default value of5432
inup.sh
.One-line summary: reconfigure docker compose to support easy db port reassignment
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)