Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RFC7230_LEGACY http compliance on application connectors by default #2524

Merged

Conversation

jlukenoff
Copy link
Contributor

Problem

When using the helm chart in the past, this config wasn't set by default, causing a basic install of the chart to fail and the issue fixed in #1419 to regress.

Solution

Add this value to the helm chart configmap by default

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

…fault

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@boring-cyborg boring-cyborg bot added the chart label Jun 17, 2023
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @jlukenoff 💯

@wslulciuc wslulciuc enabled auto-merge (squash) June 17, 2023 00:14
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #2524 (e6bea0e) into main (ad1a597) will decrease coverage by 0.78%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2524      +/-   ##
============================================
- Coverage     84.57%   83.80%   -0.78%     
- Complexity     1007     1233     +226     
============================================
  Files           193      235      +42     
  Lines          4668     5625     +957     
  Branches        232      270      +38     
============================================
+ Hits           3948     4714     +766     
- Misses          605      767     +162     
- Partials        115      144      +29     

see 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc merged commit 00b799b into MarquezProject:main Jun 17, 2023
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 5, 2023
…fault (MarquezProject#2524)

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
…fault (MarquezProject#2524)

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
…fault (MarquezProject#2524)

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
…fault (MarquezProject#2524)

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants