-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm Ingress template to be cross-compatible with recent k8s versions #2275
Update helm Ingress template to be cross-compatible with recent k8s versions #2275
Conversation
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
=========================================
Coverage 76.84% 76.84%
Complexity 1154 1154
=========================================
Files 220 220
Lines 5268 5268
Branches 423 423
=========================================
Hits 4048 4048
Misses 747 747
Partials 473 473 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @jlukenoff! 💯 🥇
FYI, would be great to have version checks for other templates within our chart as well (vs hardcoding them).
Great job! Congrats on your first merged pull request in the Marquez project! |
…ersions (MarquezProject#2275) * Update ingress template to render conditionally based on k8s version Signed-off-by: John Lukenoff <johnlukenoff@asana.com> * Extraneous end Signed-off-by: John Lukenoff <johnlukenoff@asana.com> Signed-off-by: John Lukenoff <johnlukenoff@asana.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
Problem
👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:
Closes: #2274
Solution
Certain components of the Ingress schema have changed in recent versions of Kubernetes. This PR updates the Ingress helm template to render based on the semantic kubernetes version.
Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)