temp runaway: proper cast to prevent any overflow. #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexborro
added a commit
that referenced
this pull request
Jan 4, 2015
temp runaway: proper cast to prevent any overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
(this time pull request to Dev branch, sorry about the multiple attemps)
I noticed that the temp runaway feature was not working any more in my environment:
avr-gcc (GCC) 4.9.2
avr-libc 1.8.1
arduino 1.0.5
Mendel90 + Melzi
After digging, I noticed that the operation (millis() - timer) > period_seconds1000 was always returning false, hence the proposed fix. It cast to (unsigned long) to be of the same type as millis().
Tested by setting the hotend temperature, waiting for it to be reached, and unplugging the heater wire. On the Stable branch, nothing happens, while with this fix the runaway protection fires after the desired amount of time.
This branch is based on the merge-base from Stable and Development branches.
Thanks