Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: projects input highest priority #326

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

jeremylvln
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines
- [ ] Tests for the changes have been added (if applicable)
- [ ] Docs have been added / updated (if applicable)

PR Type

What kind of change does this PR introduce?

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Other... Please describe:

What is the current behavior

Issue Number fixed #325

What is the new behavior

The projects input takes the highest priority. This ensure that setting affected to false (even if not necessary) doesn't make the code falls into the run all the projects branch.

Does this PR introduce a breaking change

- [ ] Yes
- [x] No

Other information

@jeremylvln jeremylvln self-assigned this Jan 30, 2023
@jeremylvln jeremylvln added the type:bug 🪲 Something isn't working label Jan 30, 2023
@jeremylvln jeremylvln force-pushed the fix/325-all-before-projects branch from 5c987ce to 05480d6 Compare January 30, 2023 13:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeremylvln jeremylvln merged commit 0a4e03b into main Jan 30, 2023
@jeremylvln jeremylvln deleted the fix/325-all-before-projects branch January 30, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug 🪲 Something isn't working
Development

Successfully merging this pull request may close these issues.

The "projects" paramater is ignored and nx runs all projects
1 participant